[
https://issues.apache.org/jira/browse/MATH-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483671#comment-13483671
]
Gilles commented on MATH-816:
-----------------------------
bq. for some reason I was thinking the names of the classes and the tests had
to be the same
That is usually the case indeed. But the test's class name should actually
refer to what is being tested. In this particular case, the mixture
functionality is tested through using normal distributions as components; thus,
it seemed more natural to stress that the test is about a "normal mixture
model".
(If we ever want to create unit tests for other mixtures, they can go in their
own dedicated class, and it will be more manageable than a single big class
with every possible mixtures...)
Thanks for the contribution.
> Multivariate Normal Mixture Models
> ----------------------------------
>
> Key: MATH-816
> URL: https://issues.apache.org/jira/browse/MATH-816
> Project: Commons Math
> Issue Type: New Feature
> Reporter: Jared Becksfort
> Priority: Minor
> Fix For: 3.2
>
> Attachments: MixtureMultivariateRealDistribution.java,
> MixtureMultivariateRealDistribution.java,
> MixtureMultivariateRealDistribution.java.patch,
> MixtureMultivariateRealDistributionTest.java,
> MultivariateNormalMixtureModelDistribution.java,
> MultivariateNormalMixtureModelDistributionTest.java
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> I will submit a class for Multivariate Normal Mixture Models. Not sure it
> will allow sampling initially.
> > Hello,
> >
> > I have implemented some classes for multivariate Normal distributions,
> > multivariate normal mixture models, and an expectation maximization fitting
> > class for the mixture model. I would like to submit it to Apache Commons
> > Math. I still have some touching up to do so that they fit the style
> > guidelines and implement the correct interfaces. Before I do so, I thought
> > I would at least ask if the developers of the project are interested in me
> > submitting them.
> >
> > Thanks,
> > Jared Becksfort
> Dear Jared,
> Yes, that would be very nice to have such an addition! Remember to also
> include unit tests (refer to the current ones for examples). The best would
> be to split a submission up into multiple minor ones, each covering a natural
> submission (e.g. multivariate Normal distribution in one submission), and
> create an issue as described at
> http://commons.apache.org/math/issue-tracking.html .
> If you run into any problems, please do not hesitate to ask on this mailing
> list.
> Cheers, Mikkel.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
