[
https://issues.apache.org/jira/browse/VFS-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492044#comment-13492044
]
Dave Marion commented on VFS-442:
---------------------------------
bq. 1. Get coverage as close to 100% as possible.
I'm having an issue running code coverage in Eclipse. However, I think its
close based on what I did in ACCUMULO-708
bq. 2. No need to have read-only in the class names. That's just the
capabilities of the provider today. If someone makes it read-write then there
is no need for a class rename or a new class name.
Done.
bq. 3. Always use blocks, even for one-liners: if (expr) { stmnt; }
Fixed most checkstyle issues that made sense.
bq. 4. Only make public what will be set in stone. You can make something
public tomorrow, but you cannot make it have less visibility and keep binary
compatibility.
bq. 5. Javadoc everything public.
Fixed most issues.
bq. 6. Use Java 5 enhanced for loops where possible.
bq. 7. Don't initialize ivars to their default values, for example do this:
"private FileSystem fs;", not this: "private FileSystem fs = null;"
bq. 8. Make ivars final where possible
Fixed most issues.
bq. 9. Don't make the code platform dependent, for example, on Windows 7
Added comments in test that it needs to run on Hadoop compatible
environments, need Cygwin for Windows.
Upgraded to Hadoop dependency to version 1.1.0. I will upload a new patch in
a few moments to take the place of the first patch.
> HDFS FileSystem Provider
> ------------------------
>
> Key: VFS-442
> URL: https://issues.apache.org/jira/browse/VFS-442
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 2.0
> Reporter: Dave Marion
> Priority: Minor
> Labels: accumulo, hdfs
> Attachments: VFS-442-1.patch, VFS-442-2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
