[
https://issues.apache.org/jira/browse/MATH-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575418#comment-13575418
]
Thomas Neidhart commented on MATH-932:
--------------------------------------
Hi Jens,
I now had some time to look at your contribution, which, in general is really
great.
There are several areas, as Gilles already pointed, which need more work, see
my comments below:
* there are lots of API changes, which means that we either have to wait for
4.0 to integrate
or find a way to extend the existing API in a backwards compatible way
* there are currently no tests attached, which would be a requirement for new
features to be added
* do you know how to configure checkstyle in your environment?
we have a configuration file (see checkstyle.xml) for our usual coding
style, and if patches conform to these rules it
is much easier to integrate them, if you have any questions related to it,
do not hesitate to ask
* interface naming: we prefer not to use I prefix for interfaces
* javadoc: it is required that any public/protected and classes have a proper
javadoc to describe its use
* java 6/7 features: as we still use Java 5 on source level, @Override
annotations are not allowed for methods
implementing an interface
I will take a deeper look into the class hierarchy, but wanted to give you a
quick feedback first.
Thanks,
Thomas
> Contributions to filter package
> -------------------------------
>
> Key: MATH-932
> URL: https://issues.apache.org/jira/browse/MATH-932
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Jens Kübler
> Fix For: 4.0
>
> Attachments: extendedKalmanSupport.txt
>
>
> - Extended Kalman Filter with user supplied transition functions
> - Unscented Kalman Filter
> - Rauch Tung Striebel Kalman Smoother
> - Ability to supply combinations of nonlinear and linear kalman filter
> setups, i.e. nonlinear unscented system transition with a linear
> measurment update
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
