[ 
https://issues.apache.org/jira/browse/CSV-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13611686#comment-13611686
 ] 

Benedikt Ritter edited comment on CSV-58 at 3/23/13 12:19 PM:
--------------------------------------------------------------

I have attached a new test for CSVLexer that shows how the handling of escapes 
could work.

EDIT: got a bit confused with the escape handling, so removing my patch.
                
      was (Author: britter):
    I have attached a new test for CSVLexer that shows how the handling of 
escapes could work.
                  
> Escape handling needs rethinking
> --------------------------------
>
>                 Key: CSV-58
>                 URL: https://issues.apache.org/jira/browse/CSV-58
>             Project: Commons CSV
>          Issue Type: Bug
>          Components: Parser
>            Reporter: Sebb
>             Fix For: 1.0
>
>         Attachments: commons-csv.diff
>
>
> The current escape parsing converts <esc><char> to plain <char> if the <char> 
> is not one of the special characters to be escaped.
> This can affect unicode escapes if the <esc> character is backslash.
> One way round this is to specifically check for <char> == 'u', but it seems 
> wrong to only do this for 'u'.
> Another solution would be to leave <esc><char> as is unless the <char> is one 
> of the special characters.
> There are several possible ways to treat unrecognised escapes:
> - treat it as if the escape char had not been present (current behaviour)
> - leave the escape char as is
> - throw an exception

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to