[
https://issues.apache.org/jira/browse/CHAIN-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682148#comment-13682148
]
Benedikt Ritter edited comment on CHAIN-88 at 6/13/13 11:49 AM:
----------------------------------------------------------------
{quote}
I'll have a look when I'm at home tonight :)
{quote}
Okay, it was sufficient to have a look at the patch. I agree with Simo.
Switching from a style with several try/catch blocks to the annotation based
style using {{@Test(expected)}} requires to split up the test. However I think
we should do that. It's better to have each method only test one thing.
[~stephan.koeninger] would you mind to recreate the patch with this in mind?
TIA!
was (Author: britter):
{quote}
I'll have a look when I'm at home tonight :)
{quote}
Okay, it was sufficient to have a look at the patch. I agree with Simo.
Switching from a style with several try/catch blocks to the annotation based
style using {{@Text(expected)}} requires to split up the test. However I think
we should do that. It's better to have each method only test one thing.
[~stephan.koeninger] would you mind to recreate the patch with this in mind?
TIA!
> Refactor tests in class ContextBaseTestCase
> --------------------------------------------
>
> Key: CHAIN-88
> URL: https://issues.apache.org/jira/browse/CHAIN-88
> Project: Commons Chain
> Issue Type: Improvement
> Affects Versions: 2.0
> Reporter: Stephan Köninger
> Priority: Minor
> Labels: patch
> Attachments: CHAIN-88-patch.txt
>
>
> Some tests in ContextBaseTestCase contain strange code which is much too
> complicated or seems unnecessary. I have created a patch to address this
> issues. All tests run on my machine after applying the patches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
