[
https://issues.apache.org/jira/browse/CHAIN-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13684166#comment-13684166
]
Stephan Köninger edited comment on CHAIN-88 at 6/15/13 12:59 PM:
-----------------------------------------------------------------
Hello Benedikt,
I have applied all the changes you suggested to my newest patch. I also removed
"Operation" from the method signature and reverted the line formatting in
{{testAttributes()}}. Tabs are replaced by spaces now, as well :)
Thanks to you!
Stephan
P.S.: What do you think of implementing the tests using {{assertThat}} in
combination with {{hamcrest}}? :)
was (Author: stephan.koeninger):
Hello Benedikt,
I have applied all the changes you suggested to my newest patch. I also removed
"Operation" from the method signature and reverted the line formatting in
{{testAttributes()}}. Tabs are replaced by spaces now, as well :)
Thanks to you!
Stephan
> Refactor tests in class ContextBaseTestCase
> --------------------------------------------
>
> Key: CHAIN-88
> URL: https://issues.apache.org/jira/browse/CHAIN-88
> Project: Commons Chain
> Issue Type: Task
> Affects Versions: 2.0
> Reporter: Stephan Köninger
> Priority: Minor
> Labels: patch
> Attachments: CHAIN-88-1-patch.txt, CHAIN-88-2-patch.txt,
> CHAIN-88-patch.txt
>
>
> Some tests in ContextBaseTestCase contain strange code which is much too
> complicated or seems unnecessary. I have created a patch to address this
> issues. All tests run on my machine after applying the patches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
