[ 
https://issues.apache.org/jira/browse/MATH-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13713716#comment-13713716
 ] 

Phil Steitz commented on MATH-757:
----------------------------------

Sebb - we already have too much duplicative / over-complicated clutter.  Yes, 
everyone has to change package names uniformly as we - once again - break 
compatibility throughout the library in 4.0.  At least keeping the same class 
makes it easier.  Just dropping the sync is sufficient in this case IMO.  This 
is a moderately useful class that others have used (myself included) outside of 
[math].  Lets try to maintain it simply.  The simplest way to fix this issue is 
to just drop the sync and not advertise the class as threadsafe.
                
> ResizableDoubleArray is not thread-safe yet has some synch. methods
> -------------------------------------------------------------------
>
>                 Key: MATH-757
>                 URL: https://issues.apache.org/jira/browse/MATH-757
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 4.0
>
>
> ResizableDoubleArray has several synchronised methods, but is not 
> thread-safe, because class variables are not always accessed using the lock.
> Is the class supposed to be thread-safe?
> If so, all accesses (read and write) need to be synch.
> If not, the synch. qualifiers could be dropped.
> In any case, the protected fields need to be made private.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to