[ 
https://issues.apache.org/jira/browse/MATH-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714409#comment-13714409
 ] 

Gilles commented on MATH-757:
-----------------------------

Phil,

Some time ago, you agreed to refactor this class as long as the "rolling" 
functionality remains (in this class, IIUC). A lot has already been done in 
that direction (final fields, deprecation of unsafe methods, ...).
I imagined that what I proposed in my previous comment can reconcile the 
initial goal (completing the refactoring prior to 4.0) and what Sebb would need 
prior to 3.3 (a new "clean" class, perhaps without "rolling"). It remains to be 
defined what precise functionality is necessary in this base class.

Or do I miss something?

                
> ResizableDoubleArray is not thread-safe yet has some synch. methods
> -------------------------------------------------------------------
>
>                 Key: MATH-757
>                 URL: https://issues.apache.org/jira/browse/MATH-757
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 4.0
>
>
> ResizableDoubleArray has several synchronised methods, but is not 
> thread-safe, because class variables are not always accessed using the lock.
> Is the class supposed to be thread-safe?
> If so, all accesses (read and write) need to be synch.
> If not, the synch. qualifiers could be dropped.
> In any case, the protected fields need to be made private.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to