[ 
https://issues.apache.org/jira/browse/LANG-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13731429#comment-13731429
 ] 

Dmitry Katsubo commented on LANG-909:
-------------------------------------

[[email protected]]: I will apply the code style changes you have mentioned. To 
make it easier: are there code formatting rules for Eclipse which I can 
download? This from 
[here|http://maven.apache.org/developers/conventions/code.html#Eclipse_3.2] are 
for Maven project and seem to be different from what Apache commons is using. 
Unit tests do not test different formats because from implementation it is 
clear that formatting is delegated to {{SimpleDateFormat}}; adding such test 
does not add any code or branch coverage to existing test thus to my mind it is 
useless.

[[email protected]]: Future parser looks good. Will the adapter for 
{{java.text.DateFormat}} be included? A lot of legacy/3rdparty code is based on 
that JDK API, so it would be nice to keep compatibility.
                
> Thread-safe wrapper for SimpleDateFormat
> ----------------------------------------
>
>                 Key: LANG-909
>                 URL: https://issues.apache.org/jira/browse/LANG-909
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.time.*
>    Affects Versions: 3.1
>            Reporter: Dmitry Katsubo
>            Priority: Minor
>         Attachments: ThreadSafeDateFormat.java, ThreadSafeDateFormatTest.java
>
>
> {{SimpleDateFormat}} implementation in JDK is known to be [not 
> thread-safe|http://stackoverflow.com/questions/6840803/simpledateformat-thread-safety].
>  The attached helper class solves the problem by holding a separate instance 
> of {{SimpleDateFormat}} per thread.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to