[
https://issues.apache.org/jira/browse/LANG-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13731440#comment-13731440
]
Sebb commented on LANG-909:
---------------------------
@Dmitry: before making any changes to the patch, I suggest you check whether
the FastDate* classes provide everything that SimpleDateFormat does. If not,
then probably the FastDate classes should be extended, rather than creating a
thread safe wrapper.
As to formatting - AFAIK there are no Eclipse downloads.
As for any project, keep to the existing formatting in a source file unless
otherwise advised.
Regarding test cases for different formats:
the class requires the format as a parameter to the constructor.
Therefore it is vital that the tests include more that just one format string
to ensure that the parameter is handled correctly now, and continues to be
handled correctly if the class is ever changed.
> Thread-safe wrapper for SimpleDateFormat
> ----------------------------------------
>
> Key: LANG-909
> URL: https://issues.apache.org/jira/browse/LANG-909
> Project: Commons Lang
> Issue Type: New Feature
> Components: lang.time.*
> Affects Versions: 3.1
> Reporter: Dmitry Katsubo
> Priority: Minor
> Attachments: ThreadSafeDateFormat.java, ThreadSafeDateFormatTest.java
>
>
> {{SimpleDateFormat}} implementation in JDK is known to be [not
> thread-safe|http://stackoverflow.com/questions/6840803/simpledateformat-thread-safety].
> The attached helper class solves the problem by holding a separate instance
> of {{SimpleDateFormat}} per thread.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
