[ 
https://issues.apache.org/jira/browse/LANG-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755705#comment-13755705
 ] 

Barrie Treloar commented on LANG-378:
-------------------------------------

Updated to latest version r1519171 in subversion.
But I can't get Eclipse to generate a decent patch.
Is there a sandbox area I can create a svn branch and commit into?

There is a lot of change here.
I don't think its more than necessary.
Due to the large amount of changes the patch diffs are not as good as they 
should be.
For example, to ensure immutability the member variables of ToStringStyle have 
been pushed into an inner class ToStringStyleData, but the diff doesn't show 
that these lines have been moved elsewhere they just get confused with the 
context that is left behind.

Serialization numbers have been bumped where it is no longer backwards 
compatible.
I can't see why anyone would be wanting to serialize ToStringStyle between VMs 
so it shouldn't be an issue.

Someone with intimate knowledge of commons-lang design philosophy should be 
looking at this patch carefully to make sure its not doing the wrong thing.

                
> Add new ToStyle to support MultiLine with Indent
> ------------------------------------------------
>
>                 Key: LANG-378
>                 URL: https://issues.apache.org/jira/browse/LANG-378
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.builder.*
>    Affects Versions: 2.3
>            Reporter: Barrie Treloar
>            Priority: Minor
>             Fix For: 3.x
>
>         Attachments: LANG-378-branch-3.0-r1169521.patch, 
> MultiLineWithIndentToStyle.zip
>
>
> Multiline support  places everything on a new line with no indentation to 
> help in readability.
> Attached is a patch (with tests) to support Multiline behaviour with 
> indentation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to