[ 
https://issues.apache.org/jira/browse/MATH-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778677#comment-13778677
 ] 

Gilles commented on MATH-1034:
------------------------------

Thanks for the contribution. I cannot comment on the contents. But the 
formatting is not compliant: the code seems to contain tabs.

Also, the "default" statement in the "switch" block should not assume a valid 
choice in the case of an enum: all cases must be handle explicitly (if the 
"default" is hit, that means that a new entry was added to the enum without 
appropriate update of the code using it).

                
> Add binomial test
> -----------------
>
>                 Key: MATH-1034
>                 URL: https://issues.apache.org/jira/browse/MATH-1034
>             Project: Commons Math
>          Issue Type: Wish
>    Affects Versions: 3.2
>            Reporter: Thorsten Schäfer
>            Priority: Minor
>         Attachments: binomialTest.patch
>
>
> A binomial test would be a nice addition to commons-math. I might supply a 
> patch in the near future. I guess the interface should be similar to the 
> other tests, i.e., a method to get the p-value and a method returning a 
> boolean indicating reject/non-reject.
> Is there a policy about using Enumerations in commons-math? For instance, in 
> R you can test two-sided, less or greater. This could be done using an 
> enumeration in Java, but I'm not sure if this is discouraged for backward 
> compatibility reasons...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to