[
https://issues.apache.org/jira/browse/MATH-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778946#comment-13778946
]
Phil Steitz commented on MATH-1037:
-----------------------------------
Thanks for reporting this. This is bad and the example calls it out. That
Geometric distribution test needs to be fixed. I am inclined to get rid of the
default and make getTolerance abstract so tests have to set it explicitly.
> Distribution tests are mostly meaningless due to high tolerance
> ---------------------------------------------------------------
>
> Key: MATH-1037
> URL: https://issues.apache.org/jira/browse/MATH-1037
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Aleksei Dievskii
> Priority: Minor
>
> The tolerance used for value comparison in
> {{IntegerDistributionAbstractTest}} is {{1E-4}}. However, most values being
> compared are much smaller, so they are considered equal even if they
> otherwise differ by orders of magnitude. For example, a typo in
> {{GeometricDistributionTest}} puts 29 in the test points instead of 19, while
> the test probability value is correctly given for 19. The test passes,
> disregarding the fact that {{2.437439e-05}} (test value for 19) and
> {{1.473826e-07}} (actual value for 29) differ almost hundredfold.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
