[
https://issues.apache.org/jira/browse/MATH-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793028#comment-13793028
]
Thomas Neidhart commented on MATH-1037:
---------------------------------------
Actually, the tolerance value has been overridden in the
GeometricDistributionTest, but unfortunately, the base class seems to ignore
it: instead of accessing the tolerance value by calling getTolerance(), the
class accesses the field directly.
I will fix this together with the typo in the GeometricDistributionTest.
> Distribution tests are mostly meaningless due to high tolerance
> ---------------------------------------------------------------
>
> Key: MATH-1037
> URL: https://issues.apache.org/jira/browse/MATH-1037
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Aleksei Dievskii
> Priority: Minor
>
> The tolerance used for value comparison in
> {{IntegerDistributionAbstractTest}} is {{1E-4}}. However, most values being
> compared are much smaller, so they are considered equal even if they
> otherwise differ by orders of magnitude. For example, a typo in
> {{GeometricDistributionTest}} puts 29 in the test points instead of 19, while
> the test probability value is correctly given for 19. The test passes,
> disregarding the fact that {{2.437439e-05}} (test value for 19) and
> {{1.473826e-07}} (actual value for 29) differ almost hundredfold.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
