[ 
https://issues.apache.org/jira/browse/SCXML-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810862#comment-13810862
 ] 

Woonsan Ko commented on SCXML-114:
----------------------------------

Hi Henri,

Currently we have a singleton JexlEngine instance in JexlEvaluator and the 
singleton is initialized in static block.
This seems to bring a limitation because the static singleton instance is not 
so flexible and controllable.
Also, I've just realized that JexlEvaluator itself is thread-safe, and so 
someone can use it as singleton instead. This way, I think we can keep it more 
flexible and fulfills more use cases.
Therefore, I'd like to change the JexlEngine instance from static member to 
instance member, assuming it's up to those who creates SCXMLExecutor to decide 
whether the JexlEvaluator should be singleton or not.
What do you think?

Regards,

Woonsan

P.S. I created another issue, SCXML-175, because I want to give more freedom to 
add namespaced functions in JEXL expressions/scripts. If we don't have to keep 
it as singleton any more, we can easily improve SCXML-175.

> Support for JEXL2
> -----------------
>
>                 Key: SCXML-114
>                 URL: https://issues.apache.org/jira/browse/SCXML-114
>             Project: Commons SCXML
>          Issue Type: Improvement
>            Reporter: Henri Biestro
>            Assignee: Woonsan Ko
>             Fix For: 2.0
>
>         Attachments: SCXML-114.patch, SCXML-114.patch
>
>
> JEXL 2.0 release being (hopefully) soon, it may make sense to use it instead 
> of JEXL 1.1.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to