[
https://issues.apache.org/jira/browse/SCXML-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837794#comment-13837794
]
Ate Douma commented on SCXML-177:
---------------------------------
Logging as ERROR is an improvement, but shouldn't this better result in a
ModelException instead (too)?
IMO such a SCXML definition cannot be regarded as valid when elements are
'dropped' silently.
>From this regard the SCXMLReader#reportIgnoredElement method is questionable
>itself.
Maybe we could/should introduce a 'strict' SCXMLReader flag, which when true
(default) would fail with ModelExceptions in such cases?
For backwards compatibility this 'strict' flag then could be set to false if so
desired.
WDYT?
> Correct error/warning messages in SCXML reading to be up-to-date
> ----------------------------------------------------------------
>
> Key: SCXML-177
> URL: https://issues.apache.org/jira/browse/SCXML-177
> Project: Commons SCXML
> Issue Type: Bug
> Reporter: Woonsan Ko
> Assignee: Woonsan Ko
> Priority: Trivial
> Fix For: 2.0
>
>
> Some error/warning logs are outdated against the newest spec.
> For example,
> org.apache.commons.scxml2.model.ModelException: No SCXML child state with ID
> "null" found; illegal initialstate for SCXML document
> at
> org.apache.commons.scxml2.io.ModelUpdater.logAndThrowModelError(ModelUpdater.java:297)
> It should inform of 'initial', not 'initialstate' and check if it is not set.
--
This message was sent by Atlassian JIRA
(v6.1#6144)