[
https://issues.apache.org/jira/browse/MATH-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001965#comment-14001965
]
Luc Maisonobe commented on MATH-1123:
-------------------------------------
Yes, the hull is correct and I agree colinear point can be included. It was the
BSPTree built from these points that triggered a problem.
As users could have chosen to build a convex region directly from these points,
it was really at BSP level that such points should be handled properly.
We had already encountered this problem previously, but I failed to fix it. The
previous cases were due to numerical noise, as the original point were not
exactly aligned. However, exactly aligned point do occur and should be
accepted. This new use case is really interesting since it does trigger the
problem with exact integer coordinates. I have added it as a junit test in the
general abstract test for all convex hull algorithms as it seemed interesting
even for hull themselves, even if they were not really involved this time.
> NPE in BSPTree#fitToCell()
> --------------------------
>
> Key: MATH-1123
> URL: https://issues.apache.org/jira/browse/MATH-1123
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 3.3
> Environment: Win32_64
> Reporter: Labrosse Aurélien
> Fix For: 3.4
>
> Attachments: ConvexHullTest.java, convex.png
>
>
> Hello,
> I faced a NPE using BSPTree#fitToCell() from the SVN trunk. I fixed the
> problem using a small patch I will attach to the ticket.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
