[
https://issues.apache.org/jira/browse/MATH-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002411#comment-14002411
]
Thomas Neidhart commented on MATH-1123:
---------------------------------------
Ok thanks for the update. I slightly changed the unit test to use the proper
generator.
Regarding the collinear points: they are correctly added as specified by the
flag in the constructor. If only a minimal hull shall be constructed, the
collinear points are not included. I thought this might be a useful distinction.
Unfortunately, these collinear points were quite tricky to handle for the other
algorithms that I implemented and could not get it to work reliably. Otoh,
other libraries also seem to have chosen MonotoneChain as primary algorithm for
convex hulls as it seems to be the most robust in this regard.
> NPE in BSPTree#fitToCell()
> --------------------------
>
> Key: MATH-1123
> URL: https://issues.apache.org/jira/browse/MATH-1123
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 3.3
> Environment: Win32_64
> Reporter: Labrosse Aurélien
> Fix For: 3.4
>
> Attachments: ConvexHullTest.java, convex.png
>
>
> Hello,
> I faced a NPE using BSPTree#fitToCell() from the SVN trunk. I fixed the
> problem using a small patch I will attach to the ticket.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
