[
https://issues.apache.org/jira/browse/LANG-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047212#comment-14047212
]
Benedikt Ritter commented on LANG-1016:
---------------------------------------
Hello [~juanpablo],
sorry for the late reply, I was on vacation :) about your patch:
I'm not sure about the new name. Take for example
{{NumberUtils.isHumanReadableNumber( "64,2" )}}. This is a perfectly human
readable number since in some countries the comma is used as decimal separator.
Further more your original idea was to provide a method that tells you whether
a method is parsable by {{toDouble/Long/Integer}} methods. So why should the
input {{64L}} return false? This can be parsed to a long value.
Thoughts?
> NumberUtils#isParseable method(s)
> ---------------------------------
>
> Key: LANG-1016
> URL: https://issues.apache.org/jira/browse/LANG-1016
> Project: Commons Lang
> Issue Type: Wish
> Components: lang.math.*
> Reporter: Juan Pablo Santos RodrÃguez
> Fix For: Review Patch, Discussion
>
>
> (for background see
> [LANG-997|https://issues.apache.org/jira/browse/LANG-997?focusedCommentId=13991193&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13991193])
> It would be nice to have an {{isParseable}} method (or whatever it may be
> called), to be able to identify valid (=parseable) Numbers, something along
> the lines {{toDouble(String)}} / {{toLong(String)}} etc., but returning
> {{true}} / {{false}} while avoiding at the same time the
> {{try/catch(NumberFormatException)}} of those methods.
> This method would be similar to {{isNumber}}, but it should yield {{true}}
> for invalid octals like "018" which are parseable as Numbers. The point of
> this method is to identify "human" (neither hex nor octal, but should handle
> decimal points) numbers stored as Strings,
> We are using NumberUtils#isNumber to identify valid (parseable, human)
> numbers, but as of 3.3, this method also handles octal numbers, so, f.ex.,
> 018, which was recognized as a valid number, isn't recognized anymore as one.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
