[jira] [Commented] (LANG-1016) NumberUtils#isParseable method(s)

[JIRA]

    [ 
https://issues.apache.org/jira/browse/LANG-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047255#comment-14047255
 ] 

Juan Pablo Santos Rodríguez commented on LANG-1016:
---------------------------------------------------

Hi Benedikt,

no worries, hope you've had nice holidays :-) 

As for the method name, I agree, maybe we could go back with {{isParseable}}? 
In any case, please choose whatever name you think is more suitable.

Regarding the {{64L}} issue, {{Long.parseLong( "64L" )}} yields a 
NumberFormatException, while the javadocs from Long#parseLong() state:

{quote}
\[...] 
Note that neither the character L ('\u004C') nor l ('\u006C') is permitted to 
appear at the end of the string as a type indicator, as would be permitted in 
Java programming language source code.
{quote}

So, while {{64L}} would be a valid long identificator, and 
{{NumberUtils.isNumber(..)}} would recognize it as a valid number,  it wouldn't 
be a valid "parseable" number. 

br,

> NumberUtils#isParseable method(s)
> ---------------------------------
>
>                 Key: LANG-1016
>                 URL: https://issues.apache.org/jira/browse/LANG-1016
>             Project: Commons Lang
>          Issue Type: Wish
>          Components: lang.math.*
>            Reporter: Juan Pablo Santos Rodríguez
>             Fix For: Review Patch, Discussion
>
>
> (for background see 
> [LANG-997|https://issues.apache.org/jira/browse/LANG-997?focusedCommentId=13991193&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13991193])
> It would be nice to have an {{isParseable}} method (or whatever it may be 
> called), to be able to identify valid (=parseable) Numbers, something along 
> the lines {{toDouble(String)}} / {{toLong(String)}} etc., but returning 
> {{true}} / {{false}} while avoiding at the same time the 
> {{try/catch(NumberFormatException)}} of those methods.
> This method would be similar to {{isNumber}}, but it should yield {{true}} 
> for invalid octals like "018" which are parseable as Numbers. The point of 
> this method is to identify "human" (neither hex nor octal, but should handle 
> decimal points) numbers stored as Strings, 
> We are using NumberUtils#isNumber to identify valid (parseable, human) 
> numbers, but as of 3.3, this method also handles octal numbers, so, f.ex.,  
> 018, which was recognized as a valid number, isn't recognized anymore as one.



--
This message was sent by Atlassian JIRA
(v6.2#6252)