[
https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258839#comment-14258839
]
James Sawle commented on LANG-701:
----------------------------------
Ok...
I will remove the check on the message for now, but would like to create and
issue for adding them to the public API as can be as important as the type of
exception, especially when generic exception types are used. Even if we do not
publicly expose the messages, the changes should be considered regression
unless consciously considered.
I would also like to keep the ExpectedException within the pull request as it
is the recommended standard for JUnit over the annotation method. Should we not
use best practice for one part as not the standard across the rest of the API,
especially as it is an implementation detail?
I will also make the change to remove the dependency on Java 7 libraries as
well as the use of spaces instead of tabs.
> StringUtils join with var args
> ------------------------------
>
> Key: LANG-701
> URL: https://issues.apache.org/jira/browse/LANG-701
> Project: Commons Lang
> Issue Type: New Feature
> Components: lang.*
> Reporter: Gabriele Kahlout
> Priority: Minor
> Fix For: Review Patch
>
> Attachments: VarArgJoinTest.java
>
>
> {code:java}
> final String apple = "apple";
> final String banana = "banana";
> final String orange = "orange";
> final String expected = apple + SPACE + banana + SPACE + orange;
> final String actual = join(SPACE, apple, banana, orange);
> final int expLength = expected.length();
> final int actLength = actual.length();
> assertEquals(expLength, actLength);
> assertEquals(expected, actual);
> {code}
> I missed the functionality of joining strings with the space separator in one
> line. BTW, why space ' ' not a constant field anywhere?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
