[ 
https://issues.apache.org/jira/browse/LANG-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577023#comment-14577023
 ] 

Bruno P. Kinoshita commented on LANG-1085:
------------------------------------------

Hi Oliver!

Thanks for the pull request. The timed circuit breaker has a few secondary 
classes, but I think that way it may be easier to understand the code, and 
avoid those redundant `if`'s. That way it might be easier to write tests too.

I believe now we need to tidy up the code, update the docs (I didn't pay 
attention to comments, code, tabs, etc), and then either create a pull request 
to lang or attach a new patch. What way do you think it would be easier for us 
to work on it? 

Probably it would be better if the repo was yours, as the original patch was 
yours too :-) 

Thank you!



> Add a circuit breaker implementation
> ------------------------------------
>
>                 Key: LANG-1085
>                 URL: https://issues.apache.org/jira/browse/LANG-1085
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.concurrent.*
>            Reporter: Oliver Heger
>         Attachments: CircuitBreaker.java, CircuitBreakerTest.java
>
>
> A _circuit breaker_ is a useful component to protect an application against 
> unreliable services or load peaks. A simple implementation could be a good 
> fit for the concurrent package.
> A proposed implementation is attached. Feedback is welcome!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to