[ 
https://issues.apache.org/jira/browse/LANG-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580983#comment-14580983
 ] 

Oliver Heger commented on LANG-1085:
------------------------------------

Hi Bruno!

Everything looks good. I also fully agree to the name ThresholdCircuitBreaker.

Regarding package organization: I am on the fence here. If more implementations 
are added, a separate package would be appropriate. However, I remember that in 
the past there were objections against adding too complex components to [lang]. 
Having a new package could be considered an indication that circuit breakers 
fall into this category. But I would like to have some opinions from other 
committers regarding this question.

> Add a circuit breaker implementation
> ------------------------------------
>
>                 Key: LANG-1085
>                 URL: https://issues.apache.org/jira/browse/LANG-1085
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.concurrent.*
>            Reporter: Oliver Heger
>         Attachments: CircuitBreaker.java, CircuitBreakerTest.java
>
>
> A _circuit breaker_ is a useful component to protect an application against 
> unreliable services or load peaks. A simple implementation could be a good 
> fit for the concurrent package.
> A proposed implementation is attached. Feedback is welcome!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to