[ 
https://issues.apache.org/jira/browse/VALIDATOR-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582039#comment-14582039
 ] 

Sebb commented on VALIDATOR-341:
--------------------------------

Checking for a null or zero length array may save a few instructions, but makes 
the code longer and harder to read (it uses a separate method to search the 
custom arrray).
It's really not worth the effort, especially since the custom array is only 
searched if the entry is not found in the regular array.

Special case code is to be avoided unless there are very good reasons for using 
it. That is not the case here.

> Make TLD list configurable
> --------------------------
>
>                 Key: VALIDATOR-341
>                 URL: https://issues.apache.org/jira/browse/VALIDATOR-341
>             Project: Commons Validator
>          Issue Type: New Feature
>          Components: Framework
>            Reporter: Benedikt Ritter
>              Labels: TLD, domains, email
>         Attachments: RequestForComments.patch
>
>
> Since the list of valid TLDs changes from time to time, it makes sense to let 
> users configure the list of valid TLDs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to