[
https://issues.apache.org/jira/browse/VALIDATOR-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728658#comment-14728658
]
Sebb commented on VALIDATOR-341:
--------------------------------
Thanks for the patch. However allowing the array to be updated at run-time
means that it is no longer automatically thread-safe. Also unless the array
contents are preset with the current list, it means that the array has to be
initialised each time the library is used. That is why we were considering an
add-on approach whereby only changes needed to be loaded.
Unfortunately the file tlds-alpha-by-domain.txt does not distinguish country
codes from generic TLDs. If a new country code is added to the list, it will be
considered as a generic TLD unless the COUNTRY_CODE_TLDS array is updated
first. This is why the test code downloads the html version of the page as well.
> Make TLD list configurable
> --------------------------
>
> Key: VALIDATOR-341
> URL: https://issues.apache.org/jira/browse/VALIDATOR-341
> Project: Commons Validator
> Issue Type: New Feature
> Components: Framework
> Reporter: Benedikt Ritter
> Labels: TLD, domains, email
> Attachments: RequestForComments.patch, VALIDATOR-341.diff
>
>
> Since the list of valid TLDs changes from time to time, it makes sense to let
> users configure the list of valid TLDs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
