[ 
https://issues.apache.org/jira/browse/BCEL-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706104#comment-14706104
 ] 

Mark Roberts commented on BCEL-202:
-----------------------------------

I have removed the old diff file and attached a new one.  These changes 
address/incorporate all of Daniel's comments.  Pleas note that per BCEL-248 I 
have made my changes to StackMap.java and StackMapEntry.java NOT the newer 
versions (StackMapTable.java and StackMapTableEntry.java).  I have attached 
another diff file to BCEL-248 that shows the changes necessary to delete the 
two latter files.  I have modified our Daikon tools and tested them with these 
changes and all looks good.

> StackMapTableEntry.copy() needs to be deep; Improved support for StackMaps
> --------------------------------------------------------------------------
>
>                 Key: BCEL-202
>                 URL: https://issues.apache.org/jira/browse/BCEL-202
>             Project: Commons BCEL
>          Issue Type: Bug
>            Reporter: Mark Roberts
>         Attachments: stack-map.diff
>
>
> There are several ways a user can modify a Java class file that should cause 
> BCEL to update the StackMaps automatically.  Unfortunately, it does not.  
> These additional methods at least allow users to take care of these issues 
> for themselves.
> The patch also fixes a bug - StackMapTableEntry.copy() needs to be a deep 
> copy to prevent StackMapTypes from being reused.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to