[
https://issues.apache.org/jira/browse/BCEL-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706587#comment-14706587
]
Sebb commented on BCEL-202:
---------------------------
The patch changes the public constructor parameters.
It would be better to keep the original one in case we can restore binary
compat with 5.2; I will add it back in and deprecate it
The setStackMap() method uses "int len = 2';" without explanation. What does
that represent?
[No need to update the patch; I can update the code directly]
> StackMapTableEntry.copy() needs to be deep; Improved support for StackMaps
> --------------------------------------------------------------------------
>
> Key: BCEL-202
> URL: https://issues.apache.org/jira/browse/BCEL-202
> Project: Commons BCEL
> Issue Type: Bug
> Reporter: Mark Roberts
> Attachments: stack-map.diff
>
>
> There are several ways a user can modify a Java class file that should cause
> BCEL to update the StackMaps automatically. Unfortunately, it does not.
> These additional methods at least allow users to take care of these issues
> for themselves.
> The patch also fixes a bug - StackMapTableEntry.copy() needs to be a deep
> copy to prevent StackMapTypes from being reused.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
