Github user hen commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/113#discussion_r49941082
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -8026,34 +8026,31 @@ private static boolean endsWith(final CharSequence
str, final CharSequence suffi
* @since 3.0
*/
public static String normalizeSpace(final String str) {
- // LANG-1020: Improved performance significantly by normalizing
manually instead of using regex
- // See
https://github.com/librucha/commons-lang-normalizespaces-benchmark for
performance test
if (isEmpty(str)) {
return str;
}
+ if (isBlank(str)){
+ return EMPTY;
+ }
+
final int size = str.length();
final char[] newChars = new char[size];
int count = 0;
int whitespacesCount = 0;
- boolean startWhitespaces = true;
for (int i = 0; i < size; i++) {
char actualChar = str.charAt(i);
- boolean isWhitespace = Character.isWhitespace(actualChar);
+ boolean isWhitespace = Character.isWhitespace(actualChar) ||
actualChar == '\u00A0';
--- End diff --
Noting that the javadoc doesn't indicate that nbsp is escaped. I'm +1 to
also escaping nbsp, but javadoc should be updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
