Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/pull/113#issuecomment-172354689
@garydgregory @hen Thanks for the reviews. :)
As mentioned in the jira issue the goal of this pull request is not to add
anything, but to restore pre-3.4 functionality:
These work with 3.3.2, but fail with 3.4:
```java
assertEquals("a b", StringUtils.normalizeSpace("a\u00A0 b"));
assertEquals("b", StringUtils.normalizeSpace("b\u0000"));
```
while keeping in place most of the performance improvement added in
https://github.com/apache/commons-lang/commit/bc8e23808b9d8d0c9b67270ef35d04ebd9d89cc8
I used same tests
https://github.com/librucha/commons-lang-normalizespaces-benchmark and there is
only a 10% performance regression for the restored pre-3.4 behavior (the
trimming of the string and the normalization of non-braking spaces).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
