[
https://issues.apache.org/jira/browse/COMPRESS-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213523#comment-15213523
]
Stefan Bodewig commented on COMPRESS-207:
-----------------------------------------
Thomas, your patch does a few more things than just adding notifications. In
particular you add a call to {{initBlock}} in {{read0}} and modify
{{bsGetBit}}. I've verified the change to {{bsGetBit}} and will apply it
independently, but a heads-up would have been nice. {{resetBlock}} looks like
a completely separate issue.
I've created a branch COMPRESS-207 that contains a more general proposal for
progress monitoring as I really wouldn't want to add it as a special case for
bzip2. I'll also ask the dev list for opinions on the feature itself.
> add notifier support for new block in BZip2CompressorInputStream
> ----------------------------------------------------------------
>
> Key: COMPRESS-207
> URL: https://issues.apache.org/jira/browse/COMPRESS-207
> Project: Commons Compress
> Issue Type: New Feature
> Components: Compressors
> Affects Versions: 1.4.1
> Reporter: Thomas Meyer
> Priority: Minor
> Labels: API, bzip
> Attachments:
> 0001-Add-notifier-support-for-new-block-in-BZip2Compresso.patch,
> BZip2CompressorInputStream-add-newBlock-notifier.patch,
> BZip2CompressorInputStream-add-newBlock-notifier.patch,
> BZip2CompressorInputStream-add-newBlock-notifier.patch
>
>
> hi,
> attached patch enables an program to add a listener when a new bzip2
> block is detected.
> The notifier is called with:
> - xxx.newBlock(this, currBlockPosition)
> - this = the current BZip2CompressorInputStream object
> - currBlockPosition = The offset (i.e. start position) in the compressed
> input stream of the current block
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
