[
https://issues.apache.org/jira/browse/MATH-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247707#comment-15247707
]
Gilles commented on MATH-1357:
------------------------------
bq. GitHub.com \[...\] is not the only location for contributors to open pull
requests \[...\]
That is a fact, strictly speaking.
It's quite possible to use command-line tools to issue a pull request (cf. my
"experiment" above).
I don't think that the source tree of an Apache project should manage layout
from other repositories/applications (contributions could come from other
public repositories in addition to Github).
But it would be interesting to ask for other opinions on the issue. Would you
post to the "dev" ML?
bq. \[...\] putting .github/PULL_REQUEST_TEMPLATE.md in place.
How does the Github application use this template?
Is it possible to run consistency checks (such as checking the number of
commits, or that a JIRA report exists and insert the info automatically in the
request, or insert the result of the run of tools such as "CheckStyle")? If
so, it would be nice to leverage...
In the meantime I suggest to use the "doc/development" directory. We can
always move the info/template to more appropriate places later.
bq. Regarding the checkbox, I'm agnostic on whether that's included \[...\]
It's not a matter of belief ;).
If it's necessary, then it must be there; if not required, then it should not
be there.
Please ask on the "dev" ML (with a post subject prefixed with "\[ALL\]").
> Create Github Pull Request Template
> -----------------------------------
>
> Key: MATH-1357
> URL: https://issues.apache.org/jira/browse/MATH-1357
> Project: Commons Math
> Issue Type: New Feature
> Affects Versions: 3.6.1
> Reporter: Rob Tompkins
> Priority: Trivial
> Labels: github
> Fix For: 3.7
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> I would like to have at the root of {{commons-math}} a directory named
> {{.github}} with a file named {{PULL_REQUEST_TEMPLATE.md}} that automatically
> populates the body of pull requests.
> For example, angular.js has the following
> https://raw.githubusercontent.com/angular/angular.js/master/.github/PULL_REQUEST_TEMPLATE.md
> Further we can include anything between the delimiters {{<!-- Some comment
> here -->}} will be seen by the github user opening the pull request, but not
> actually included in the comment. For example consider the one on the
> spring-boot project:
> https://raw.githubusercontent.com/spring-projects/spring-boot/master/.github/PULL_REQUEST_TEMPLATE.md
> I would propose we have the following:
> * A link to the CONTRIBUTING.md file in the project, which explains how to
> contribute. I would include this in the {{<!-- -->}} delimited section, as it
> is unnecessary to actually persist into the github pull request comment body.
> * A request to link to a Jira ticket number (which is relatively trivial to
> include).
> * A checkbox for the apache contributor agreement having been signed and
> emailed in.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
