[
https://issues.apache.org/jira/browse/CODEC-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285592#comment-15285592
]
Gary Gregory commented on CODEC-211:
------------------------------------
The advantage is that the enum has methods on the instance side which avoids
all of the duplication of all the current methods in {{DigestUtils}}. We almost
do not need DigestUtils but for a few methods now that we have the enum (or
class). Same for {{HmacUtils}}.
Granted, this can also be done in a class. I think I would be OK with a class
rather than an enum then. Feel free to update the code if you have time now.
I wonder if we should also have a new enum or class called
{{StandardMessageDigestAlgorithm}} like there is a {{StandardCharsets}} class.
To make it clear what is standard and not.
> Create enum MessageDigestAlgorithm and deprecate class MessageDigestAlgorithms
> ------------------------------------------------------------------------------
>
> Key: CODEC-211
> URL: https://issues.apache.org/jira/browse/CODEC-211
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.10
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T08:41:47-08:00)
> Maven home: E:\Java\apache-maven-3.3.9\bin\..
> Java version: 1.7.0_79, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_79\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> Reporter: Gary Gregory
> Assignee: Gary Gregory
> Fix For: 1.11
>
>
> Create enum MessageDigestAlgorithm and deprecate class
> MessageDigestAlgorithms.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
