[
https://issues.apache.org/jira/browse/CODEC-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285681#comment-15285681
]
Sebb commented on CODEC-211:
----------------------------
There is no need to have duplicate methods in DigestUtils if the algorithm name
is added as a parameter.
This is what the enum call does:
MessageAlgorithm.MD5.digest(byte[]) =>
DigestUtils.digest(DigestUtils.getDigest(MessageAlgorithms.MD5), byte[])
By adding some general digest(String, input) methods to DigestUtils, this could
become:
DigestUtils.digest(MessageAlgorithms.MD5, byte[])
which is just about as easy to use as
MessageAlgorithm.MD5.digest(byte[])
I will fix up the code
> Create enum MessageDigestAlgorithm and deprecate class MessageDigestAlgorithms
> ------------------------------------------------------------------------------
>
> Key: CODEC-211
> URL: https://issues.apache.org/jira/browse/CODEC-211
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.10
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T08:41:47-08:00)
> Maven home: E:\Java\apache-maven-3.3.9\bin\..
> Java version: 1.7.0_79, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_79\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> Reporter: Gary Gregory
> Assignee: Gary Gregory
> Fix For: 1.11
>
>
> Create enum MessageDigestAlgorithm and deprecate class
> MessageDigestAlgorithms.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
