[
https://issues.apache.org/jira/browse/COMPLEX-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15806010#comment-15806010
]
ASF GitHub Bot commented on COMPLEX-1:
--------------------------------------
GitHub user RayDeCampo opened a pull request:
https://github.com/apache/commons-complex/pull/1
[COMPLEX-1] Testing fails
Fix equals methods in Complex and Quaternion by copying over Precision from
commons-math. Made Precision package protected and removed parts not used by
code currently in commons-complex. This fixes ComplexTest and QuaternionTest
unit tests.
Fix RootsOfUnityTest by changing test methods to expect the correct
exception class.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RayDeCampo/commons-complex COMPLEX-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-complex/pull/1.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1
----
commit f7cca80f4a6913f22829ad5dfcebd980ce5289cd
Author: Ray DeCampo <[email protected]>
Date: 2017-01-06T22:35:51Z
[COMPLEX-1] Fix equals methods in Complex and Quaternion by copying over
Precision from commons-math. Made Precision package protected and removed
parts not used by code currently in commons-complex. This fixes ComplexTest
and QuaternionTest unit tests.
Fix RootsOfUnityTest by changing test methods to expect the correct
exception class.
----
> Testing fails due to poor null handling in newly created local equals() and
> equals-type methods
> -----------------------------------------------------------------------------------------------
>
> Key: COMPLEX-1
> URL: https://issues.apache.org/jira/browse/COMPLEX-1
> Project: Commons Complex
> Issue Type: Bug
> Reporter: Eric Barnhill
> Labels: patch, test
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> commons-complex currently compiles but fails tests. Patches are needed to
> handle null in the testing methods.
> Local equals() methods have been created to eliminate dependencies on other
> Math packages, but these appear to not handle null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
