[
https://issues.apache.org/jira/browse/COMPLEX-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15808432#comment-15808432
]
ASF GitHub Bot commented on COMPLEX-1:
--------------------------------------
GitHub user RayDeCampo opened a pull request:
https://github.com/apache/commons-complex/pull/2
[COMPLEX-1] Testing fails due to poor null handling in newly created local
equals() and equals-type methods
Use Precision.equals() in TestUtils where appropriate.
Use IllegalArgumentException in ComplexUtils instead of RuntimeException
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RayDeCampo/commons-complex COMPLEX-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-complex/pull/2.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2
----
commit c11baf2d397134c700b17a1603b041d49e2af01e
Author: Ray DeCampo <[email protected]>
Date: 2017-01-07T16:58:40Z
[COMPLEX-1] Use Precision.equals() in TestUtils where appropriate.
Use IllegalArgumentException in ComplexUtils instead of RuntimeException
commit 2926b81702424c6ed92b19959266e8bd72cb8991
Author: Ray DeCampo <[email protected]>
Date: 2017-01-08T00:53:42Z
Merge branch 'master' into COMPLEX-1
----
> Testing fails due to poor null handling in newly created local equals() and
> equals-type methods
> -----------------------------------------------------------------------------------------------
>
> Key: COMPLEX-1
> URL: https://issues.apache.org/jira/browse/COMPLEX-1
> Project: Commons Complex
> Issue Type: Bug
> Reporter: Eric Barnhill
> Labels: patch, test
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> commons-complex currently compiles but fails tests. Patches are needed to
> handle null in the testing methods.
> Local equals() methods have been created to eliminate dependencies on other
> Math packages, but these appear to not handle null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
