[
https://issues.apache.org/jira/browse/COMPRESS-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056344#comment-16056344
]
ASF GitHub Bot commented on COMPRESS-410:
-----------------------------------------
GitHub user sesuncedu reopened a pull request:
https://github.com/apache/commons-compress/pull/36
COMPRESS-410 Remove Non-NIO character set encoders.
As a special case, the UTF-8 encoder will replace malformed / unmappable
input with '?'.
This behavior is required for compatibility with existing behavior.
Signed-off-by: Simon Spero <[email protected]>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sesuncedu/commons-compress COMPRESS-410
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-compress/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit 1c9e1d8218ccd102567273eebdfba187ca545fc8
Author: Simon Spero <[email protected]>
Date: 2017-06-17T00:17:13Z
COMPRESS-410 Remove Non-NIO character set encoders.
As a special case, the UTF-8 encoder will replace malformed / unmappable
input with '?'.
This behavior is required for compatibility with existing behavior.
Signed-off-by: Simon Spero <[email protected]>
commit 7fdfde85a8ab19c1f47efe4d3a9d0bad653182b2
Author: Simon Spero <[email protected]>
Date: 2017-06-17T16:45:44Z
javadoc for HasCharset
Signed-off-by: Simon Spero <[email protected]>
commit 651eae5399ba5b980257703b0ff98d7f7d89aee3
Author: Simon Spero <[email protected]>
Date: 2017-06-18T22:55:38Z
Do better estimating of required buffer size for character encoding. If an
unencodable character is found that requires output buffer expansion, scan
buffer for all such characters, and attempt to expand buffer only once.
Signed-off-by: Simon Spero <[email protected]>
commit c9dfc31dbbbe099927a843197936b19e41f64d5c
Author: Simon Spero <[email protected]>
Date: 2017-06-11T22:48:42Z
COMPRESS-407 Validate Block and Record Sizes
Require block size >=0 that is multiple of 512 bytes.
Use block size of 512 if one is not given.
Require record size of 512 bytes. Deprecate constructors taking recordSize
as parameter
Modify tests to check for enforcement of record size == 512
Modify tests to check for correct overall length for
different block sizes including PAX default, USTAR default, and unspecified.
Signed-off-by: Simon Spero <[email protected]>
commit 15764594371bd8792b28d6cb415b9fcf1a9a60c2
Author: Michael Hausegger <[email protected]>
Date: 2017-06-13T21:47:50Z
add-some-Unit-Tests Added some Unit Tests to increase code coverage.
commit 9d81c8fcad4cbedcbe0cfd81a7af492800d1f726
Author: Simon Spero <[email protected]>
Date: 2017-06-15T18:27:48Z
Redoing more buffer stuff
Signed-off-by: Simon Spero <[email protected]>
commit 40736df64b5360f3ea3ad481ed81b47bd6650b30
Author: Simon Spero <[email protected]>
Date: 2017-06-15T18:27:48Z
Redoing more buffer stuff
Signed-off-by: Simon Spero <[email protected]>
commit ead6bc6db225d8da124e37d67ecd081e3167d0ca
Author: Simon Spero <[email protected]>
Date: 2017-06-15T23:26:12Z
More ByteBuffer methods for TarUtils
Signed-off-by: Simon Spero <[email protected]>
commit ab95c59eabdd283ec993bab7559b14864c1bcc57
Author: Simon Spero <[email protected]>
Date: 2017-06-16T20:24:12Z
More ByteBuffer methods for TarUtils
Signed-off-by: Simon Spero <[email protected]>
commit a5db19a7ff84114033d3e8411e1a02497e0c1bd8
Author: Michael Hausegger <[email protected]>
Date: 2017-06-16T18:12:20Z
add-some-Unit-Tests Removed @author tags in comments.
commit 028b81cf85547edc7c54b6ab8c4395ac8c931c20
Author: Michael Hausegger <[email protected]>
Date: 2017-06-16T18:22:10Z
add-some-Unit-Tests Removed test testGetValueThrowsNullPointerException in
class ChecksumCalculatingInputStreamTest. Test represented a bug/defect which
is going to be fixed in a different branch.
commit 3908b334156c8f5a44ac3777d73adb80f0f973d2
Author: Michael Hausegger <[email protected]>
Date: 2017-06-16T18:38:00Z
add-some-Unit-Tests Minor variable renaming.
commit e5c2cce4f9b7f3aca848b3c608c77f5c7911a662
Author: Michael Hausegger <[email protected]>
Date: 2017-06-16T18:44:40Z
add-some-Unit-Tests Added myself as contributor to pom.xml as "requested"
by Stefan Bodewig.
commit 04109a4d0924b7a79319e2ce382bc9fedea51a65
Author: Michael Hausegger <[email protected]>
Date: 2017-06-16T20:16:06Z
add-some-Unit-Tests Added additional Unit Tests.
commit d7195a8bc61d151227540521b723ca580bd26dab
Author: Simon Spero <[email protected]>
Date: 2017-06-17T15:54:15Z
Initial support for ByteBuffer header output
Signed-off-by: Simon Spero <[email protected]>
commit e0af41ce1ddb38f6dd1cb8fbe979f737827a685e
Author: Simon Spero <[email protected]>
Date: 2017-06-17T16:45:06Z
More ByteBuffer header output
Signed-off-by: Simon Spero <[email protected]>
commit 64638a98e87f87a7d22e2a84be363416a098fbb4
Author: Simon Spero <[email protected]>
Date: 2017-06-18T20:00:03Z
Remove previous HasCharset.
More ByteBuffer based header parsing
Signed-off-by: Simon Spero <[email protected]>
commit c260dbd1e4ed1ead2519e52a4842fdd9287585f7
Author: Simon Spero <[email protected]>
Date: 2017-06-18T22:55:05Z
Use ISO-LATIN-1 as fallback encoding instead of custom zip encoding.
Does not truncate characters or terminate decoding on encountering null
input.
Signed-off-by: Simon Spero <[email protected]>
commit e2cfdabed7c93205625b7b57e21b1a73051fe3ba
Author: Simon Spero <[email protected]>
Date: 2017-06-18T23:27:42Z
Test that ebcidic encoding is supported (making sure "%Uxxxx" replacement
strings don't use ascii encodings)
Signed-off-by: Simon Spero <[email protected]>
----
> Remove ZipEncoding implementations introduced to work around problems in
> jdk 1.4
> ----------------------------------------------------------------------------------
>
> Key: COMPRESS-410
> URL: https://issues.apache.org/jira/browse/COMPRESS-410
> Project: Commons Compress
> Issue Type: Improvement
> Components: Archivers
> Affects Versions: 1.14
> Reporter: Simon Spero
> Priority: Minor
>
> There are several implementations of ZipEncoding that are provided to work
> around missing character sets in JDK 1.4.
> Since commons-compress requires JDK7 or later, this code is no longer needed.
> As the classes are package private, they can be removed without affecting the
> API.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
