[
https://issues.apache.org/jira/browse/COMPRESS-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074958#comment-16074958
]
ASF GitHub Bot commented on COMPRESS-410:
-----------------------------------------
Github user bodewig commented on the issue:
https://github.com/apache/commons-compress/pull/37
Thanks a lot Simon,
Please take a look at fde6670 - I've only performed some minor changes that
I didn't feel like hackling you for. Things that may be a tiny bit more than
just cosmetics:
* I'm not sure why you went for the literal string `UTF-8` rather than the
constant and `isUTF8` method in `ZipEncodingHelper`, I've changed that (kinda)
back
* I've removed the `assert` from `NioZipEncoding.encode`
> Remove ZipEncoding implementations introduced to work around problems in
> jdk 1.4
> ----------------------------------------------------------------------------------
>
> Key: COMPRESS-410
> URL: https://issues.apache.org/jira/browse/COMPRESS-410
> Project: Commons Compress
> Issue Type: Improvement
> Components: Archivers
> Affects Versions: 1.14
> Reporter: Simon Spero
> Priority: Minor
> Fix For: 1.15
>
>
> There are several implementations of ZipEncoding that are provided to work
> around missing character sets in JDK 1.4.
> Since commons-compress requires JDK7 or later, this code is no longer needed.
> As the classes are package private, they can be removed without affecting the
> API.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
