[
https://issues.apache.org/jira/browse/COMPRESS-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060253#comment-16060253
]
ASF GitHub Bot commented on COMPRESS-407:
-----------------------------------------
GitHub user sesuncedu opened a pull request:
https://github.com/apache/commons-compress/pull/41
COMPRESS-407 - Just Warn
Warn if an invalid record size is set.
I would not recommend using this approach.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sesuncedu/commons-compress COMPRESS-407-WARN
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-compress/pull/41.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #41
----
commit f0c21325faf6f613821a8b542c73ac380f0feb6a
Author: Simon Spero <[email protected]>
Date: 2017-06-11T22:48:42Z
COMPRESS-407 Validate Block and Record Sizes
Require block size >=0 that is multiple of 512 bytes.
Use block size of 512 if one is not given.
Require record size of 512 bytes. Deprecate constructors taking recordSize
as parameter
Modify tests to check for enforcement of record size == 512
Modify tests to check for correct overall length for
different block sizes including PAX default, USTAR default, and unspecified.
Signed-off-by: Simon Spero <[email protected]>
(cherry picked from commit d754d89)
Signed-off-by: Simon Spero <[email protected]>
commit abab94288a8b8de05ecfade6517456a2c8dc6fb2
Author: Simon Spero <[email protected]>
Date: 2017-06-23T00:35:13Z
COMPRESS-407 Validate Block sizes. Detect invalid record sizes, but just
log a warning.
Signed-off-by: Simon Spero <[email protected]>
----
> Validate Block and Record Sizes
> -------------------------------
>
> Key: COMPRESS-407
> URL: https://issues.apache.org/jira/browse/COMPRESS-407
> Project: Commons Compress
> Issue Type: Sub-task
> Components: Archivers
> Reporter: Simon Spero
>
> Reject record sizes not equal to 512 bytes; require block sizes to be
> multiples of 512 bytes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
