GitHub user BruceKuiLiu opened a pull request:

    https://github.com/apache/commons-lang/pull/297

    Add a rule of Locale.ENGLISH to String.toUpperCase() method.

    A String is being converted to upper case, using the platform's default 
encoding.
    This may result in improper conversions when used with international 
characters.
    Use the String.toUpperCase( Locale l ) version should be better.
    http://findbugs.sourceforge.net/bugDescriptions.html#DM_CONVERT_CASE

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BruceKuiLiu/commons-lang master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #297
    
----
commit ac6ea81247282d7fd929195040acf333cebc7b80
Author: Kui LIU <[email protected]>
Date:   2017-10-09T14:01:42Z

    Add a rule of Locale.ENGLISH to String.toUpperCase() method.
    
    A String is being converted to upper case, using the platform's default 
encoding.
    This may result in improper conversions when used with international 
characters.
    Use the String.toUpperCase( Locale l ) version should be better.
    http://findbugs.sourceforge.net/bugDescriptions.html#DM_CONVERT_CASE

----


---

Reply via email to