GitHub user BruceKuiLiu reopened a pull request:
https://github.com/apache/commons-lang/pull/297
Add a rule of Locale.ENGLISH to String.toUpperCase() method.
A String is being converted to upper case, using the platform's default
encoding.
This may result in improper conversions when used with international
characters.
Use the String.toUpperCase( Locale l ) version should be better.
http://findbugs.sourceforge.net/bugDescriptions.html#DM_CONVERT_CASE
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BruceKuiLiu/commons-lang master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/297.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #297
----
commit ac6ea81247282d7fd929195040acf333cebc7b80
Author: Kui LIU <[email protected]>
Date: 2017-10-09T14:01:42Z
Add a rule of Locale.ENGLISH to String.toUpperCase() method.
A String is being converted to upper case, using the platform's default
encoding.
This may result in improper conversions when used with international
characters.
Use the String.toUpperCase( Locale l ) version should be better.
http://findbugs.sourceforge.net/bugDescriptions.html#DM_CONVERT_CASE
commit 52696462449c37ed58457aa6e8a9b63a33863608
Author: Kui LIU <[email protected]>
Date: 2017-10-09T14:45:22Z
Add a rule of Locale.ENGLISH to String.toLowerCase() method.
A String is being converted to lower case, using the platform's default
encoding.
This may result in improper conversions when used with international
characters.
Use the String.toLowerCase( Locale l ) version should be better.
http://findbugs.sourceforge.net/bugDescriptions.html#DM_CONVERT_CASE
commit e5a77b7ac0195943ee9ab5a40e826102f5b7b19a
Author: Kui LIU <[email protected]>
Date: 2017-10-09T14:47:32Z
Add a rule of Locale.ENGLISH to String.toUpperCase() method.
A String is being converted to upper case, using the platform's default
encoding.
This may result in improper conversions when used with international
characters.
Use the String.toUpperCase( Locale l ) version should be better.
http://findbugs.sourceforge.net/bugDescriptions.html#DM_CONVERT_CASE
commit c3711c3d6d93fdc996bddc97e3dffa60f6c0119d
Author: Kui LIU <[email protected]>
Date: 2017-10-09T14:48:19Z
Add a rule of Locale.ENGLISH to String.toLowerCase() method.
A String is being converted to lower case, using the platform's default
encoding.
This may result in improper conversions when used with international
characters.
Use the String.toLowerCase( Locale l ) version should be better.
http://findbugs.sourceforge.net/bugDescriptions.html#DM_CONVERT_CASE
commit 0fc92622493b45d83c05574e16a4117ae54c7d72
Author: Kui LIU <[email protected]>
Date: 2017-10-09T14:49:45Z
Add a rule of Locale.ENGLISH to String.toLowerCase() method.
A String is being converted to lower case, using the platform's default
encoding.
This may result in improper conversions when used with international
characters.
Use the String.toLowerCase( Locale l ) version should be better.
http://findbugs.sourceforge.net/bugDescriptions.html#DM_CONVERT_CASE
commit 989d02714efd99dad76380f88bbd7c430ccf92ec
Author: Kui LIU <[email protected]>
Date: 2017-10-09T14:51:22Z
Add a rule of Locale.ENGLISH to String.toUpperCase() method.
A String is being converted to upper case, using the platform's default
encoding.
This may result in improper conversions when used with international
characters.
Use the String.toUpperCase( Locale l ) version should be better.
http://findbugs.sourceforge.net/bugDescriptions.html#DM_CONVERT_CASE
commit b08cfbb3847f58a10c6dcc15ee08da3b0e2b1d6a
Author: Kui LIU <[email protected]>
Date: 2017-10-09T18:04:34Z
Add an instanceof test in the implementation of equals(Object obj) method.
The equals(Object obj) method shouldn't make any assumptions about the type
of obj. It should simply return false if obj is not the same type as this.
http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS
----
---
