[
https://issues.apache.org/jira/browse/NUMBERS-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350558#comment-16350558
]
Gilles commented on NUMBERS-65:
-------------------------------
Commit ea2c1d79d8b482bed262541e813d037294e6b572 modified a unit test in
{{RootsOfUnityTest}} to show that the implementations agree up to some
tolerance.
They however do not produce the same numbers exactly; it would be nice to
ensure that the more accurate is retained.
> "RootsOfUnity" vs "nthRoot"
> ---------------------------
>
> Key: NUMBERS-65
> URL: https://issues.apache.org/jira/browse/NUMBERS-65
> Project: Commons Numbers
> Issue Type: Task
> Components: complex
> Reporter: Gilles
> Priority: Major
> Labels: API, delete
> Fix For: 1.0
>
>
> There is partial overlap of functionality between class {{RootsOfUnity}} and
> method {{nthRoot}} (in class {{Complex}}).
> The latter is more general (any complex number) but the former allows a
> negative argument (to specify clockwise ordering).
> Also, the implementations are different; it should be checked which is more
> accurate (and then account for possible performance trade-offs).
> API-wise, I think that we should keep {{nthRoot}} (and delete
> {{RootsOfUnity}}).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
