[ https://issues.apache.org/jira/browse/NUMBERS-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444023#comment-16444023 ]
Gilles commented on NUMBERS-65: ------------------------------- bq. if RootsOfUnity is eliminated, I don't think any of the tests need to be transferred. Those for negative argument (the functionality to be added to {{nthRoot}})? > "RootsOfUnity" vs "nthRoot" > --------------------------- > > Key: NUMBERS-65 > URL: https://issues.apache.org/jira/browse/NUMBERS-65 > Project: Commons Numbers > Issue Type: Task > Components: complex > Reporter: Gilles > Priority: Major > Labels: API, delete, gsoc2018 > Fix For: 1.0 > > > There is partial overlap of functionality between class {{RootsOfUnity}} and > method {{nthRoot}} (in class {{Complex}}). > The latter is more general (any complex number) but the former allows a > negative argument (to specify clockwise ordering). > Also, the implementations are different; it should be checked which is more > accurate (and then account for possible performance trade-offs). > API-wise, I think that we should keep {{nthRoot}} (and delete > {{RootsOfUnity}}). -- This message was sent by Atlassian JIRA (v7.6.3#76005)