[
https://issues.apache.org/jira/browse/IMAGING-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581313#comment-16581313
]
ASF GitHub Bot commented on IMAGING-154:
----------------------------------------
Github user sebbASF commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210327438
--- Diff:
src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java ---
@@ -327,7 +331,7 @@ private BmpImageContents readImageContents(final
InputStream is,
switch (bhi.compression) {
case BI_RGB:
if (verbose) {
--- End diff --
Seems to me it would be better to use the log-level alone to control what
is being logged.
So the verbose flag would become a log-level instead.
> Remove Debug class
> ------------------
>
> Key: IMAGING-154
> URL: https://issues.apache.org/jira/browse/IMAGING-154
> Project: Commons Imaging
> Issue Type: Task
> Affects Versions: Patch Needed
> Reporter: Benedikt Ritter
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Fix For: 1.0
>
>
> Low level libraries should not do logging, but communicate through the use of
> exceptions and meaningful return values. Remove the Debug class and all it's
> uses.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
