[
https://issues.apache.org/jira/browse/IMAGING-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582219#comment-16582219
]
ASF GitHub Bot commented on IMAGING-154:
----------------------------------------
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210521304
--- Diff:
src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java ---
@@ -327,7 +331,7 @@ private BmpImageContents readImageContents(final
InputStream is,
switch (bhi.compression) {
case BI_RGB:
if (verbose) {
--- End diff --
You are both correct @garydgregory , @sebbASF .
I tried to remove the flags `DEBUG` or `isDebug()` or `getDebug()` by
`LOGGER.isLoggable(Level.FINE)`, but forgot to do the same for `verbose` using
the `INFO` level (wonder if we should use FINEST for debug, and FINE for the
verbose messages...)
Will just log to info. I believe we can assume that
> Remove Debug class
> ------------------
>
> Key: IMAGING-154
> URL: https://issues.apache.org/jira/browse/IMAGING-154
> Project: Commons Imaging
> Issue Type: Task
> Affects Versions: Patch Needed
> Reporter: Benedikt Ritter
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Fix For: 1.0
>
>
> Low level libraries should not do logging, but communicate through the use of
> exceptions and meaningful return values. Remove the Debug class and all it's
> uses.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
