[ 
https://issues.apache.org/jira/browse/LANG-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586240#comment-16586240
 ] 

Benedikt Ritter commented on LANG-1410:
---------------------------------------

It's a common pattern that we do the assignment of the string size in one go 
with the length check. We do this in other methods as well: stripStart, 
capitalize, uncapitalize. One could argue (and I would agree with that) that 
this is kind of confusing, because we do a check and an assignment in one go. 
Feel free to create a PR to change this, if you like.

> StringsUtil.isBlank check null first
> ------------------------------------
>
>                 Key: LANG-1410
>                 URL: https://issues.apache.org/jira/browse/LANG-1410
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>    Affects Versions: 3.7
>            Reporter: Yifan Guo
>            Priority: Minor
>
> StringsUtil.isBlank should check null for cs first instead of declaring int 
> strLen first.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to