[jira] [Commented] (LANG-1410) StringsUtil.isBlank check null first

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/LANG-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721355#comment-16721355
 ] 

ASF GitHub Bot commented on LANG-1410:
--------------------------------------

Github user asciborek commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/392#discussion_r241740720
  
    --- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
    @@ -338,15 +338,17 @@ public static boolean isAllEmpty(final 
CharSequence... css) {
          * @since 3.0 Changed signature from isBlank(String) to 
isBlank(CharSequence)
          */
         public static boolean isBlank(final CharSequence cs) {
    -        int strLen;
    --- End diff --
    
    I think that name strLen is more informative


> StringsUtil.isBlank check null first
> ------------------------------------
>
>                 Key: LANG-1410
>                 URL: https://issues.apache.org/jira/browse/LANG-1410
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>            Reporter: Yifan Guo
>            Priority: Minor
>
> StringsUtil.isBlank should check null for cs first instead of declaring int 
> strLen first.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)