[ 
https://issues.apache.org/jira/browse/GEOMETRY-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644710#comment-16644710
 ] 

Gilles commented on GEOMETRY-14:
--------------------------------

bq. Currently, I think I just want to keep it the way it is and maybe ponder if 
there are any better options.

Since I cannot offer a concrete alternative, it's quite fine as an attempt to 
improve on the previous implementation, but since part of the design is not 
"mathematically pure" (because of the Cartesian system of coordinates being so 
high in the class hierarchy), I deem it necessary that you write a summary of 
the design decisions (with known advantages and shortcomings) so that we don't 
flip-flop every time someone thinks there is some "obvious" flaw in the code 
structure.

bq. Rotation be a separate class that implements Transform from core but is not 
part of the AffineTransform hierarchy

Why?
It would also seem to be going away from the goal of "mathematically pure".

> AffineTransform?D Classes
> -------------------------
>
>                 Key: GEOMETRY-14
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-14
>             Project: Apache Commons Geometry
>          Issue Type: New Feature
>            Reporter: Matt Juntunen
>            Priority: Major
>              Labels: pull-request-available
>
> We should create AffineTransform?D classes that implement matrix-based affine 
> transforms. They should have simple methods for creating translations, 
> rotations, and scaling and calculating the inverse.
>  
> Pull Request #1: https://github.com/apache/commons-geometry/pull/14



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to