[ 
https://issues.apache.org/jira/browse/GEOMETRY-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714718#comment-16714718
 ] 

Matt Juntunen commented on GEOMETRY-14:
---------------------------------------

This is [finally] almost done. I have all of the functionality and tests in 
place and I'm just polishing up the docs and making sure that the reports are 
clean. The code is not currently using the commons-numbers {{Quaternion}} class 
but I'm thinking I'll at least create a merge request so we can start reviewing 
this code while we get NUMBERS-80 sorted out. There's quite a bit here.

I do have one question, though: when should a class _not_ be a VALJO? I 
currently have most of the classes for this issue using the "of" VALJO factory 
methods but I'm not entirely sure if they should be VALJOs. For example, 
{{AxisAngleSequence}} contains enum references and primitive doubles. Should 
this be a VALJO or not? I want to decide this now so the rest of the library 
will be consistent.

> AffineTransform?D Classes
> -------------------------
>
>                 Key: GEOMETRY-14
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-14
>             Project: Apache Commons Geometry
>          Issue Type: New Feature
>            Reporter: Matt Juntunen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.0
>
>
> We should create AffineTransform?D classes that implement matrix-based affine 
> transforms. They should have simple methods for creating translations, 
> rotations, and scaling and calculating the inverse.
>  
> Pull Request #1: https://github.com/apache/commons-geometry/pull/14



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to