[ 
https://issues.apache.org/jira/browse/NUMBERS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726774#comment-16726774
 ] 

Gilles commented on NUMBERS-86:
-------------------------------

Could you elaborate about the changes (moving the call {{positivePolarForm()}}? 
 What was the problem with the previous version?

Please avoid making different kinds of changes (code vs test vs Javadoc) within 
the same commit: You know what's important because you wrote it; but for a 
reviewer, it is unnecessarily tedious to sort them out.

> Slerp Unit Tests
> ----------------
>
>                 Key: NUMBERS-86
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-86
>             Project: Commons Numbers
>          Issue Type: Test
>            Reporter: Matt Juntunen
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> {{Slerp}} needs unit tests. There are tests in commons-geometry but they rely 
> on {{Vector3D}}. We need to port those tests or write new ones.
>  
> Pull request: https://github.com/apache/commons-numbers/pull/23



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to