[
https://issues.apache.org/jira/browse/NUMBERS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727171#comment-16727171
]
Gilles commented on NUMBERS-86:
-------------------------------
bq. except in the single situation
Does it warrant the additional method?
IMHO it obscures that single case; perhaps clearer to fix the old code and add
a prominent comment:
{code}
} else if (t == 1) {
// Call to "positivePolarForm()" is required because "end" might
// not be in positive polar form.
return end.positivePolarForm();
}
{code}
WDYT?
> Slerp Unit Tests
> ----------------
>
> Key: NUMBERS-86
> URL: https://issues.apache.org/jira/browse/NUMBERS-86
> Project: Commons Numbers
> Issue Type: Test
> Reporter: Matt Juntunen
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{Slerp}} needs unit tests. There are tests in commons-geometry but they rely
> on {{Vector3D}}. We need to port those tests or write new ones.
>
> Pull request: https://github.com/apache/commons-numbers/pull/23
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
